Skip to content

Commit

Permalink
Creating pull request template (#385)
Browse files Browse the repository at this point in the history
Summary:
Having a pull request template should standardize the content that comes through in our community PRs (and our own as well). This should hopefully encourage people to *test* their changes and show us how they did.

Thanks to https://github.com/stevemao/github-issue-templates for the base for this PR template.
Closes #385

Differential Revision: D8611387

Pulled By: JackUrb

fbshipit-source-id: 8e3c2fc0664335d93d1841f6375eed1ca3bdebe5
  • Loading branch information
JackUrb authored and facebook-github-bot committed Jun 25, 2018
1 parent c17d73a commit a56a951
Showing 1 changed file with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, experiments you ran to see how -->
<!--- your change affects existing areas of the code and their behaviors, etc. -->
<!--- One method of testing is to run the `demo.py` script from the examples -->
<!--- both on your branch and a clean branch and ensure that none of the functionality -->
<!--- appears different. Be sure to install from source when testing. -->

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] For JavaScript changes, I have re-generated the minified JavaScript code.

0 comments on commit a56a951

Please sign in to comment.