Creating pull request template #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a pull request template should standardize the content that comes through in our community PRs (and our own as well). This should hopefully encourage people to *test* their changes and show us how they did.
lvdmaaten
approved these changes
Jun 23, 2018
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| - [ ] My code follows the code style of this project. | ||
| - [ ] My change requires a change to the documentation. | ||
| - [ ] I have updated the documentation accordingly. |
There was a problem hiding this comment.
"[ ] For JavaScript changes, I have re-generated the minified JavaScript code."
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, experiments you ran to see how --> | ||
| <!--- your change affects existing areas of the code and their behaviors, etc. --> |
There was a problem hiding this comment.
I am wondering if we should include some tips and tricks for testing changes here? In particular, how to do a local pip install to test Python changes, and how to test JavaScript changes / re-generate minified JS.
There was a problem hiding this comment.
@JackUrb is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a pull request template should standardize the content that comes through in our community PRs (and our own as well). This should hopefully encourage people to test their changes and show us how they did.
Thanks to https://github.com/stevemao/github-issue-templates for the base for this PR template.