Cleanup sparse tests #208
Merged
Cleanup sparse tests #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Looks like doc failures are unrelated? |
Doc failure now fixed :) unrelated indeed |
fmassa
commented
Feb 7, 2022
Comment on lines
+117
to
118
| def values(self): | ||
| return self.__values |
There was a problem hiding this comment.
We now unify obtaining the values of the sparse tensor under the same API, which follows the API from PyTorch
|
Merging, as this is a harmless PR wrt functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With #202 merged, we can now have a single entry-point for testing that sparse tensors behave as expected, with a unified set of tests to cover the required operators.
I've removed
test_sparse_csr.pyas it is now redundant compared totest_sparse_tensors.py.I think a next step would be to clean
test_custom_ops.pyso that they test the bare minimum and doesn't depend on the legacySparseCStensor.