Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Rotary embeddings respecting input types #326

Merged
merged 2 commits into from Jun 6, 2022
Merged

[fix] Rotary embeddings respecting input types #326

merged 2 commits into from Jun 6, 2022

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Fixes #325 I hope + extending the unit test

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 馃檭
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2022
@blefaudeux blefaudeux requested a review from dianaml0 June 4, 2022 01:03
@blefaudeux blefaudeux requested a review from fmassa June 4, 2022 23:25
dianaml0
dianaml0 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@dianaml0 dianaml0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@blefaudeux blefaudeux merged commit bcb7075 into main Jun 6, 2022
@blefaudeux blefaudeux deleted the issue_325 branch June 6, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianaml0 dianaml0 dianaml0 approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotary embeddings convert queries and keys to float32 when using mixed precision training
3 participants
@blefaudeux @dianaml0 @facebook-github-bot