Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][DRAFT] Updating triton to a recent release #418

Closed
wants to merge 1 commit into from
Closed

[chore][DRAFT] Updating triton to a recent release #418

wants to merge 1 commit into from

Conversation

blefaudeux
Copy link
Contributor

@blefaudeux blefaudeux commented Sep 22, 2022 •
edited

What does this PR do?

Bump up the triton package that xformers works against, to track the changes there. There were some syntax changes which required fixes in the dropout layer. I'm hoping that this fixes some bf16 issues which were visible for some layers some time ago

Before submitting

  • Did you have fun?
    • Well, moonlighting on this so it took a while 馃檭
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

updating triton to a recent release
c4ab454 
adding a basic triton random check
updating the plots to a more representative GPU (A6000) and new triton package (no tuning)
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2022
@blefaudeux blefaudeux marked this pull request as draft September 22, 2022 21:49
@blefaudeux
Copy link
Contributor Author

the (relative to pytorch) perf regressed on the dropout case, I used a more straightforward code but it looks like it had an impact, I'll fix that

@blefaudeux blefaudeux changed the title [chore] Updating triton to a recent release [chore][DRAFT] Updating triton to a recent release Sep 22, 2022
@blefaudeux
Copy link
Contributor Author

linear layers must be updated in a similar fashion as dropout, closing the PR and reopening when ready

@blefaudeux blefaudeux closed this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa Awaiting requested review from fmassa

@danthe3rd danthe3rd Awaiting requested review from danthe3rd

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blefaudeux @facebook-github-bot