MemEff: BUGFIX when a batch has no keys #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
danthe3rd
pushed a commit
that referenced
this pull request
Oct 25, 2022
ghstack-source-id: 58eadab5d0eccc24d2975fc4cc0eb33ed4914d5c Pull Request resolved: #492
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Oct 25, 2022
ghstack-source-id: 2a43a75c065b4a89857b984a5b9081d30bcbb95c Pull Request resolved: #492
fmassa
approved these changes
Oct 25, 2022
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Oct 26, 2022
ghstack-source-id: daf5a7bc458b0b9991eb8b7495769fe0f481ad04 Pull Request resolved: #492
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Oct 27, 2022
ghstack-source-id: 84e11de209464a6a51347f9ba6b08258782bf139 Pull Request resolved: #492
|
Causes some performance regression (about 0.5%) so let's not fix it |
|
@danthe3rd what happens then in this case? Does it raise an error or just yield wrong numbers? If it yields wrong results, then I think this is a silent but that should be fixed. |
Well I'm not even sure what should happen. If there are some queries but no key/no value, I guess it should be zero? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):