Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nit][dropout] Add a no-op codepath for p=0 #57

Merged
merged 1 commit into from
Oct 29, 2021
Merged

[nit][dropout] Add a no-op codepath for p=0 #57

merged 1 commit into from
Oct 29, 2021

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Fixes #56, could be that the unit test was a little strict (check that the tensor is the same when the dropout probability is 0. An example of a faulty run is there, not obvious where the difference is, I've added a printout for hypothetical future issues

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 馃檭
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2021
@blefaudeux
Copy link
Contributor Author

assuming it's small enough to be ok to land @jieru-hu @dianaml0

@blefaudeux blefaudeux merged commit 13d2e46 into main Oct 29, 2021
@blefaudeux blefaudeux changed the title [nit][dropbox] Add a no-op codepath for p=0 [nit][dropout] Add a no-op codepath for p=0 Oct 29, 2021
@blefaudeux blefaudeux deleted the triton_dropout_unittestfix branch October 29, 2021 23:16
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
@fmassa
Add sputnik as a dependency (facebookresearch#57)
85862ef 
For now don't use submodules for simplicity. Only changes from the original repo was that I copied 3 cu.cc files and renamed them to be cu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieru-hu jieru-hu Awaiting requested review from jieru-hu

@dianaml0 dianaml0 Awaiting requested review from dianaml0

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Failing triton dropout test
2 participants
@blefaudeux @facebook-github-bot