Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MHA: Stricter input validation #592

Merged
merged 2 commits into from Dec 15, 2022
Merged

MHA: Stricter input validation #592

merged 2 commits into from Dec 15, 2022

Conversation

danthe3rd
Copy link
Contributor

@danthe3rd danthe3rd commented Dec 15, 2022 •
edited

MHA: Stricter input validation
1652dd2 
[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Dec 15, 2022
MHA: Stricter input validation
9972795 
ghstack-source-id: 9881e58fd13488c0b64aa4c9e4f070a49974bca3
Pull Request resolved: #592
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2022
fmassa
fmassa approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I have a few non-blocking suggestions, but which I think would improve user experience.

Let me know what you think!

xformers/ops/fmha/common.py Outdated Show resolved Hide resolved
xformers/ops/fmha/__init__.py Outdated Show resolved Hide resolved
xformers/ops/fmha/common.py Outdated Show resolved Hide resolved
This was referenced Dec 15, 2022
Merged
Merged
@danthe3rd danthe3rd merged commit 3660e0f into gh/danthe3rd/63/base Dec 15, 2022
danthe3rd pushed a commit that referenced this pull request Dec 15, 2022
MHA: Stricter input validation
532d702 
ghstack-source-id: 8e2247471d03ab5e961678a29b723c1c2244e301
Pull Request resolved: #592
@danthe3rd danthe3rd deleted the gh/danthe3rd/63/head branch December 15, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danthe3rd @fmassa @facebook-github-bot