Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ST handle Git files naturally #119

Merged
merged 1 commit into from Sep 3, 2018

Conversation

michaelblyons
Copy link

Fixes #116

@facelessuser
Copy link
Owner

Test failures can be ignored as they are unrelated; I have to update the document handling portion as things have changed.

I don't initially see any issues, but I'll take a closer look tomorrow. Thanks for the pull!

@facelessuser facelessuser merged commit 96022cc into facelessuser:master Sep 3, 2018
Copy link
Author

@michaelblyons michaelblyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I screw up here? Should it be \\.git instead of git in the file_path?

@facelessuser
Copy link
Owner

facelessuser commented Dec 12, 2018

Isn't it \\.git already? Or am I missing something?

@michaelblyons
Copy link
Author

Both the removed and added lines look kind of like this:

    {"file_path": ".*/git/config$"},
    {"file_path": ".*\\\\git\\\\config$"}

which will match **/git/config. But I think they should be

    {"file_path": ".*/\\.git/config$"},
    {"file_path": ".*\\\\\\.git\\\\config$"}

to match **/.git/config. Note the dot that is present here, but missing in the first set.

I have an additional rule in my local settings that is masking the problem for me, so I didn't notice the lack of the dot.

@facelessuser
Copy link
Owner

Huh, yup, we are missing the dot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants