Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standardized name for palette entry #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FichteFoll
Copy link

@FichteFoll FichteFoll commented Jan 8, 2023

I keep not finding them because entering prefapply doesn't yield the expected result.

I keep not finding them because enterinf `prefapply` doesn't yield the expected result.
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: settings Related to Sublime settings. C: source Related to source code. labels Jan 8, 2023
@facelessuser
Copy link
Owner

I'm not necessarily opposed to preference vs settings, but I generally try to prefix all plugin commands with the plugin name.

@facelessuser
Copy link
Owner

Also, it is mentioned "standardized". Where is this standard? Generally, I've standardized my commands as described above.

@FichteFoll
Copy link
Author

FichteFoll commented Jan 8, 2023

Mostly it's something that I noticed as a trend in many packages being used and also adapted into the template file for PackageDev. Though I just saw that I forgot to add "Settings" at the end (also in the template).
Another argument to group it behind "Preferences" is that this is where it would go in the main menu file.

2023-01-08_19-39-49

https://github.com/SublimeText/PackageDev/blob/742c8154f15d1f9fdb2bc868ca4a4b086ac304c6/plugins/new_resource_file/templates.py#L37-L50

@facelessuser
Copy link
Owner

Okay, let me think about this. It definitely breaks the convention I've been following, specifically for preferences. I may look at a bigger sample size. I'll take a serious look and consider this as a real possibility. If I end up making the change in this plugin, I imagine it I'll be making this change in all my plugins as I update them, so I want to make sure this is something I want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: settings Related to Sublime settings. C: source Related to source code. S: needs-review Needs to be reviewed and/or approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants