"search_threshold" setting

[andoro]

Hello!

My question is why did you set this limit to only 5000 characters?
I nearly removed your plugin because in some cases it didn't show the end of a tag in a larger >30000 character long HTML file.
The plugin works perfectly even in a 100000 character HTML too, so that's all!

[facelessuser]

My question is why did you set this limit to only 5000 characters?

I need an arbitrary limit. Not everyone's computer will perform the same. A conservative value will work on everyone's computer. That way people can evaluate that it works without it slowing down their machine. After they are satisfied, they can push it to its limits. The plugin can slow down typing etc. if the threshold is too big.

I nearly removed your plugin because in some cases it didn't show the end of a tag in a larger >30000 character long HTML file.
The plugin works perfectly even in a 100000 character HTML too, so that's all!

I worked hard to make it run with as little lag as I could, so yes the actual limit on some computers can be pushed well over what I set as default. I show in the readme that the threshold is configurable: https://github.com/facelessuser/BracketHighlighter#settings

I don't show this in the readme, but if you look in the settings file, you can ignore the threshold all together (I would not advise this though):

    // Ignore threshold
    "ignore_threshold": false,

Even if the threshold is there to protect against performance issues, on-demand plugin commands all ignore the threshold. So if you want to jump to the other bracket with the BH jump to left/right bracket command, this should work regardless of threshold setting. There is even an on-demand match command, so if BH doesn't match your bracket because the distance is too great, just use the match command and it will force the match.

In short, it is there to protect your performance first and foremost. Once you install it, you can push it to whatever limit you like.

[facelessuser]

Since the question was answered. I will close this issue.

[andoro]

Thx for your quick answer. I appreciate your hard work in connection with speed.
Well, you are right, the setting is there. I just wanted to tell you, if I were you I'd communicate this setting more highlighted (for new users) :)

[KostiantynKondratiuk]

Не работает(.