-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve: Use the newer API for opening settings #78
Conversation
This will open default and user settings side by side closes facelessuser#77
Thanks for pull. I am considering adding this. I was purposely avoiding for a while now, but enough people may be on versions that support it now to move in this direction. I wish I liked this behavior more than I do, but I may merge it regardless of how I feel because I think people in general probably want it. |
As for the flake8 issue, yeah flake8 has been being weird recently. I don't know what they are doing on their side, but I know they changed some of their internals which as broken interaction with certain flake8 plugins. I know I can't use the latest flake8 and flake8-putty. |
Ah, I see your point. Since this was released in september which is only 3 months. |
Maybe now? |
:) maybe. |
I think the overall experience is nicer. Though you use backward compatibility. |
This week I plan on making a new ColorHelper release that locks it to 3124+. So I won't be concerned with backwards compatibility. I actually have a number of plugins that I will be doing this to. I'm preparing for a new mdpopups release that will require 3124+ and will drop legacy baggage. |
Cool, I have to admit. Realy cool stuff you make possible |
@stoivo, Thanks! I wish I had more time to do all I want with them all, but I am glad people like them 🙂 . |
This will open default and user settings side by side
closes #77
I had some trouble setting up test locally but I committed and make a PR so the test can run on Travis