Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the actual matching selector (not just the name) #12

Closed
FichteFoll opened this issue Feb 18, 2015 · 6 comments
Closed

Display the actual matching selector (not just the name) #12

FichteFoll opened this issue Feb 18, 2015 · 6 comments
Labels
P: maybe Pending approval of low priority request. T: enhancement Enhancement.

Comments

@FichteFoll
Copy link

Current behavior:

foreground selector:           Function (definition)

Suggested behavior:

foreground selector:           Function (definition) <entity.name.function>

This also solves use cases where the name is not set.


In a similar regard, I'd prefer if the implicit foreground and background matches from the general settings were highlighted a bit differently so it's easier to see.

And finally, what does "simulated trans" mean? Since it always shows the same as the "normal" color I'd suggest to add an option for hiding it.

@facelessuser
Copy link
Owner

I still take a look and see what I can do.

And finally, what does "simulated trans" mean? Since it always shows the same as the "normal" color I'd suggest to add an option for hiding it.

Not always 😄. Some themes will use a transparent color. This of course shows a color that mixes the color behind it with itself giving you the color you actually see. Though, I will probably make it am optional setting. I did this because was thinking about showing the color in the tooltip, I am not sure yet how limited CSS support is yet.

@facelessuser facelessuser added T: enhancement Enhancement. P: maybe Pending approval of low priority request. Priority - Low labels Feb 18, 2015
@FichteFoll
Copy link
Author

Ah, I see. That makes sense and is a nice addition, but it should only be displayed when it's actually different from the original (=transparency is used) since it's rather rare from my experience.

@facelessuser
Copy link
Owner

That's a good idea.

@facelessuser
Copy link
Owner

Okay, simulated transparency actually wasn't working right, but it is working now, and it will only show up when there is something important to show. c858321.

So, one down. One to go.

@facelessuser
Copy link
Owner

Finished adding this in commit 6b32719.

@FichteFoll
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: maybe Pending approval of low priority request. T: enhancement Enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants