Fix atypical achromatic response cases in ray trace #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM16, HCT, ZCAM, etc. often have atypical achromatic responses due to adapting luminance and background luminance handling. Ray trace now better handles such cases by averaging the achromatic component values giving an approximate achromatic value in the RGB space that is more appropriate. This prevents cutoffs near white at high luminance levels. On rare occasions MINDE gamut mapping can be a little more accurate in these cases, but differences are imperceptible making the speed boost generally more preferable.
gir-bot
added
S: needs-review
|
@gir-bot lgtm |
gir-bot
added
S: approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAM16, HCT, ZCAM, etc. often have atypical achromatic responses due to adapting luminance and background luminance handling. Ray trace now better handles such cases by averaging the achromatic component values giving an approximate achromatic value in the RGB space that is more appropriate. This prevents cutoffs near white at high luminance levels. On rare occasions MINDE gamut mapping can be a little more accurate in these cases, but differences are imperceptible making the speed boost generally more preferable.