Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined channel changes #79

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Undefined channel changes #79

merged 7 commits into from
Oct 4, 2021

Conversation

facelessuser
Copy link
Owner

@facelessuser facelessuser commented Sep 30, 2021 •
edited
Loading

  • Allow none keyword
  • Allow interpolation result channel to return with a undefined channel
    if both channels under interpolation are none
  • Allow printing CSS with none keywords (disabled by default)

Ref: w3c/csswg-drafts#6107

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: hsl HSL colors. C: hsv HSV colors. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. labels Sep 30, 2021
@facelessuser
Copy link
Owner Author

I'm not 100% sure about forcing hue undefined yet when colors are white and black.

I think I'm okay with black, maybe okay with white on HSL, HSV, and HWB, less sure about Lch-ish color spaces.

@facelessuser facelessuser force-pushed the feature/none branch 7 times, most recently from 8b233e7 to ca2cc27 Compare October 3, 2021 21:34
@facelessuser
Undefined channel changes
5393a83 
- Allow none keyword
- Allow interpolation result channel to return with a undefined channel
  if both channels under interpolation during interpolation are none
- Allow printing CSS with none keywords (disabled by default)
@facelessuser
Default serialization of Color() shows nones but string output won't
2b6ccc3 
By default the object serialization will show `none`, but when
converting to a string, the user will need to specify the option if they
desire it.

Also, adjust some examples and fix some documentation typos
@facelessuser
Fix missing condition and no_nan to accept a default value
a0e3bfd
@facelessuser
Ensure none preference is passed to base to_string
a06f4db
@facelessuser
Update API with missing info about dynamic delta_e methods
d9eda06
@facelessuser
Copy link
Owner Author

I see nothing wrong with generally allowing none. While details on considering white forcing hue to be none is still being debated or alpha being treated as 1 when none, I think the rest can be merged.

This was referenced Oct 4, 2021
Closed
Closed
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Oct 4, 2021
@facelessuser facelessuser merged commit 9df8707 into master Oct 4, 2021
@facelessuser facelessuser deleted the feature/none branch October 4, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: docs Related to documentation. C: hsl HSL colors. C: hsv HSV colors. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@facelessuser @gir-bot