fix path conversion protocol #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, we will use the notation `///c:/path` when converting an an absolute drive path to a URL. `//` means use the current default protocol. This isn't necessarily correct in the way we are using it. Instead we should use either apply the `file://` scheme to all our converted links or strip the default assumed protocol. For now we are going to strip the assumed default protocol.
Add a test that covers windows paths for relative links. Also consolidate windows specific path 2 url conversion to one place.
facelessuser
force-pushed
the
protocol-fix
branch
from
75aafba
to
fc5fd36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, we will use the notation
///c:/pathwhen converting an an absolute drive path to a URL.//means use the current default protocol. This isn't necessarily correct in the way we are using it. Instead we should either apply thefile://scheme to all our converted links or strip the default assumed protocol. For now we are going to strip the assumed default protocol.