Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #180

Merged
merged 10 commits into from
Sep 10, 2023
Merged

Upgrade GitHub Actions #180

merged 10 commits into from
Sep 10, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 10, 2023

Also, remove redundant settings.

Also, remove redundant settings.
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: infrastructure Related to project infrastructure. labels Sep 10, 2023
Copy link
Owner

@facelessuser facelessuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there may be some good things in here, there are a lot of large, opinionated decisions being made about how we should perform our actions in this PR. I would have appreciated a discussion first about the proposed changes as that would have saved you some time.

I don't mind upgrading actions, I also don't mind removing deadsnakes. I'm also not against bumping max-parallel, but I don't think I'm interested in the other changes.

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@cclauss
Copy link
Contributor Author

cclauss commented Sep 10, 2023

Why is Python 3.11 not a required test?

@facelessuser
Copy link
Owner

Originally, I was trying out the "required" tests option. I always forget to update new tests and remove old tests. I don't have non-required tests, so I will remove the "required" settings.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 10, 2023

Added if: matrix.tox-env == 'documents' then install Aspell

@facelessuser
Copy link
Owner

I guess I am okay with docs and lint as they do appear separate now.

I do need continue-on-error easily configurable. The current setup does not allow this and I consider it a regression.

@facelessuser
Copy link
Owner

Yeah, as soon as you include one, the tests don't run unless they are all defined, which is why I just define them all.

@facelessuser facelessuser added S: requires-changes Awaiting updates after a review. and removed S: needs-review Needs to be reviewed and/or approved. labels Sep 10, 2023
@gir-bot gir-bot added the S: needs-review Needs to be reviewed and/or approved. label Sep 10, 2023
@facelessuser
Copy link
Owner

Thanks for your patience, I think everything looks okay now.

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. S: requires-changes Awaiting updates after a review. labels Sep 10, 2023
@facelessuser facelessuser merged commit b58a196 into facelessuser:master Sep 10, 2023
11 checks passed
@cclauss cclauss deleted the patch-1 branch September 10, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: infrastructure Related to project infrastructure. S: approved The pull request is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants