Ensure attribute selectors match tags that have new lines chars in at…

…tr (#234) Fixes #233
facelessuser · Nov 10, 2021 · 8a53482 · 8a53482
1 parent dad06a5
commit 8a53482
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 4 deletions.
diff --git a/docs/src/markdown/about/changelog.md b/docs/src/markdown/about/changelog.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.3.1
+
+- **FIX**: Ensure attribute selectors match tags that have new lines characters in attributes. (#233)
+
 ## 2.3
 
 - **NEW**: Officially support Python 3.10.

diff --git a/soupsieve/__meta__.py b/soupsieve/__meta__.py
@@ -192,5 +192,5 @@ def parse_version(ver: str) -> Version:
     return Version(major, minor, micro, release, pre, post, dev)
 
 
-__version_info__ = Version(2, 3, 0, "final")
+__version_info__ = Version(2, 3, 1, "final")
 __version__ = __version_info__._get_canonical()
diff --git a/soupsieve/css_parser.py b/soupsieve/css_parser.py
@@ -484,12 +484,12 @@ def parse_attribute_selector(self, sel: _Selector, m: Match[str], has_selector:
         value = ''
 
         if case:
-            flags = re.I if case == 'i' else 0
+            flags = (re.I if case == 'i' else 0) | re.DOTALL
         elif util.lower(attr) == 'type':
-            flags = re.I
+            flags = re.I | re.DOTALL
             is_type = True
         else:
-            flags = 0
+            flags = re.DOTALL
 
         if op:
             if m.group('value').startswith(('"', "'")):

diff --git a/tests/test_level3/test_attribute.py b/tests/test_level3/test_attribute.py
@@ -60,3 +60,53 @@ def test_attribute_contains(self):
             ["0", "3", "pre"],
             flags=util.HTML
         )
+
+    def test_attribute_contains_with_newlines(self):
+        """Test attribute `*=` will match with new lines."""
+
+        self.assert_selector(
+            "<p><span id='1' title='foo bar'>foo1</span><span id='2' title='foo\nbar'>foo1</span></p>",
+            "span[title*='bar']",
+            ["1", "2"],
+            flags=util.HTML
+        )
+
+    def test_attribute_starts_with_newlines(self):
+        """Test attribute `^=` will match with new lines."""
+
+        self.assert_selector(
+            "<p><span id='1' title='foo bar'>foo1</span><span id='2' title='foo\nbar'>foo1</span></p>",
+            "span[title^='foo']",
+            ["1", "2"],
+            flags=util.HTML
+        )
+
+    def test_attribute_ends_with_newlines(self):
+        """Test attribute `$=` will match with new lines."""
+
+        self.assert_selector(
+            "<p><span id='1' title='foo bar'>foo1</span><span id='2' title='foo\nbar'>foo1</span></p>",
+            "span[title$='bar']",
+            ["1", "2"],
+            flags=util.HTML
+        )
+
+    def test_attribute_dash_list_with_newlines(self):
+        """Test attribute `|=` will match with new lines."""
+
+        self.assert_selector(
+            "<p><span id='1' title='fo-o bar'>foo1</span><span id='2' title='fo-o\nbar'>foo1</span></p>",
+            "span[title|='fo']",
+            ["1", "2"],
+            flags=util.HTML
+        )
+
+    def test_attribute_space_list_with_newlines(self):
+        """Test attribute `~=` will match with new lines."""
+
+        self.assert_selector(
+            "<p><span id='1' title='foo bar baz'>foo1</span><span id='2' title='foo\nbar baz'>foo1</span></p>",
+            "span[title~='baz']",
+            ["1", "2"],
+            flags=util.HTML
+        )