Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible fix for conda-forge (only import bs4 when typing) #232

Closed
wants to merge 3 commits into from
Closed

Possible fix for conda-forge (only import bs4 when typing) #232

wants to merge 3 commits into from

Conversation

facelessuser
Copy link
Owner

@facelessuser facelessuser commented Nov 4, 2021 •
edited
Loading

Fixes #231

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: API Related to the API. C: source Related to source code. labels Nov 4, 2021
@facelessuser facelessuser mentioned this pull request Nov 4, 2021
Closed
@gir-bot gir-bot added the C: css-matching Related to CSS matching. label Nov 4, 2021
@gir-bot gir-bot added the C: docs Related to documentation. label Nov 4, 2021
@facelessuser
Copy link
Owner Author

As conda-forge's issue seemed to be related to them not including bs4 as a dependency during testing, we no longer need to make any kind of changes. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: API Related to the API. C: css-matching Related to CSS matching. C: docs Related to documentation. C: source Related to source code. S: needs-review Needs to be reviewed and/or approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circular dependency /bs4
2 participants
@facelessuser @gir-bot