-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The comments are hard to read when "highlight_line" is set to true in Packages/User/Preferences.sublime-settings #2
Comments
Yup, this is using official Dracula colors: https://github.com/dracula/dracula-theme#color-palette. I'm not saying it isn't flawed though. So this matches the official color palette: I personally prefer something a little more based off the background: |
I'm not sure if there is anything I should do here. This scheme is meant to follow the Dracula color scheme as specified. I can maybe see us adding a custom one that takes an opinionated approach with some of the color contrasting...or the whole project can just deviate with an opinionated approach... I mean, I don't have to provide a pure Dracula experience, but this is mainly provided as a modern Sublime color scheme compared to the official one still locked on to the old tmTheme style. When using classic style, I'm often using a classic style based my spin on the Pro color scheme. Unfortunately, I have not released these: |
Okay. |
I'm going to leave this open as I decide what I want to do. I generally agree that the selection highlight is a little poorly selected. Originally this was meant to provide a base for the official color scheme to work off of so they could update their old tmTheme file, but they've kind of sat on that issue, and it looks like they are content with the old tmTheme 🤷. I can do whatever I want here, I just need to decide what that is. |
Maybe, at the very least, we can provide some suggested overrides in the readme. That is if we want to ship a pure Dracula color scheme, but provide improvements. |
Apologies for being brief. My thought was: what does the community gain by this being a reference implementation of Dracula? Make it your own and improve it I say :) |
That's fair, and what I've been grappling with. I'm already doing that on my private branch. Why not here as well. |
I've decided to add a variant called |
|
See screenshot
The text was updated successfully, but these errors were encountered: