Make users.incremental() work like tickets.incremental() #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok this is SUUUUUPER awesome! |
cryptomail
reviewed
Sep 8, 2023
| @@ -706,6 +706,8 @@ class EndpointFactory(object): | |||
| users.deleted = PrimaryEndpoint("deleted_users") | |||
| users.groups = SecondaryEndpoint('users/%(id)s/groups.json') | |||
| users.incremental = IncrementalEndpoint('incremental/users.json') | |||
| users.incremental.cursor_start = IncrementalEndpoint( | |||
There was a problem hiding this comment.
hmmm yes seems parity was not here :)
cryptomail
reviewed
Sep 8, 2023
| @@ -706,6 +706,71 @@ def incremental(self, start_time, include=None, per_page=None): | |||
| per_page=per_page) | |||
|
|
|||
|
|
|||
| class IncrementalCursorApi(IncrementalApi): | |||
|
Currently manually testing. Tests pass as-is right now, but I'd like to at least run a few scripts before merge and publish. |
|
Do you have some test cases you're running now? |
cryptomail
reviewed
Sep 9, 2023
|
|
||
| .. code-block:: python | ||
|
|
||
| for ticket in reversed(zenpy_client.tickets.incremental(cursor='xxx')): |
There was a problem hiding this comment.
you did not write this, but this example face plants :)
for ticket in zenpy_client.tickets.incremental(cursor="MTY4NDYzNDU0Mi4wfHw2fA=="):
print(ticket)
jteitelbaum@Q7T6X1LF2M pythontests % python3 incremental_users_test.py
Traceback (most recent call last):
File "/Users/jteitelbaum/Code/pythontests/incremental_users_test.py", line 29, in <module>
for ticket in zenpy_client.tickets.incremental(cursor="MTY4NDYzNDU0Mi4wfHw2fA=="):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jteitelbaum/Code/zenpy/zenpy/lib/api.py", line 770, in incremental
raise ValueError(
ValueError: Can't set cursor param and paginate_by_time=True
cryptomail
reviewed
Sep 9, 2023
|
|
||
| .. code-block:: python | ||
|
|
||
| for ticket in reversed(zenpy_client.tickets.incremental(cursor='xxx')): |
|
Administratively closed due to issue being resolved with superceding PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
Disclaimer: I'm not familiar with Zendesk, I'm working on my first integration right now during which I encountered the issue. This PR does seem to fix it, though.