Fix HMR options being ignored (fixes #106) #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options.reloadAll` had no effect, because they were incorrectly copied into the webpack's loader.options and could never reach `hotModuleReplacement.js`. This commit fixes the copy site, allowing for options to pass through. Fixes faceyspacey#106
|
|
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 2, 2018
* fix(index.js): Improved HMR detection multi instance collisions addressed Merging a PR which improved upon my initial code which allowed the plugin to automatically hot reload. With the help of React Static, we are able to fix a bug that appeared when building out build toolchains. This bug causes the pugin to have two seperate context references within webpack and ends up passing incorrect references to the wrong instance. Deceptivally simple solution was naming the context key myself. * fix(nested-loaders-hmr): Fix n-depth nested loader usage where HMR fails (#103) HMR doesn't work when loaders are nested * fix(nested-loaders-hmr): Fix n-depth nested loader usage where HMR fails (#103) HMR doesn't work when loaders are nested * feat(HMR):Adding the ability to enable hot options. Like reload all, or css moduels CSS Modules option * use throw error, not console error * use throw error, not console error * fixing error thrown by empty options object * Fix HMR options being ignored (fixes #106) (#107) `options.reloadAll` had no effect, because they were incorrectly copied into the webpack's loader.options and could never reach `hotModuleReplacement.js`. This commit fixes the copy site, allowing for options to pass through. Fixes #106 * changed context string to match webpack conventions * version bump * perp for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.reloadAllhad no effect, because they were incorrectly copied into the webpack'sloader.optionsand could never reachhotModuleReplacement.js. This commit fixes the copy site, allowing for options to pass through. Fixes #106