Add phpstan #29
Add phpstan #29
Conversation
.travis.yml
Outdated
| @@ -14,6 +14,9 @@ matrix: | |||
| include: | |||
| - php: 7.1 | |||
| env: | |||
| - TEST_PHPSTAN=true | |||
There was a problem hiding this comment.
Why to instantiate another PHP 7.1 environment?
.travis.yml
Outdated
| @@ -41,6 +42,7 @@ install: | |||
|
|
|||
| script: | |||
| - if [[ $TEST_COVERAGE ]]; then phpdbg -qrr bin/phpunit --coverage-clover clover.xml; else bin/phpunit; fi; | |||
| - if [[ $TEST_PHPSTAN ]]; then php ./bin/phpstan analyse -l 7 src fi; | |||
There was a problem hiding this comment.
We should analyse tests directory too. I think it would be better to add the phpstan configuration and required extensions if necessary
src/Connection.php
Outdated
| @@ -14,17 +14,20 @@ | |||
| */ | |||
| class Connection extends DBALConnection | |||
| { | |||
| /** @var ServerGoneAwayExceptionsAwareInterface */ | |||
| protected $_driver; | |||
There was a problem hiding this comment.
We shouldn't override this property just to assign a different phpdoc.
src/Connection.php
Outdated
| @@ -129,7 +133,7 @@ public function query() | |||
| * @param array $params | |||
| * @param array $types | |||
| * | |||
| * @return integer The number of affected rows. | |||
| * @return integer|null The number of affected rows. | |||
There was a problem hiding this comment.
This method should not return null
src/Statement.php
Outdated
| @@ -45,7 +45,7 @@ private function createStatement() | |||
| /** | |||
| * @param array|null $params | |||
| * | |||
| * @return bool | |||
| * @return bool|null | |||
There was a problem hiding this comment.
This method should not return null
|
php5.6 will be supported (security) until 31 Dec 2018. i would prefer to keep compatibility up to those dates. when we'll bump the minimum php version will be also useful to update the README in order to provide a compatibility version matrix. thanks again for this pr! |
|
@alexmanno |
|
@alexmanno may you have a look at this? |
|
no answer from @alexmanno, |
No description provided.