Don't lose state of statement on retry #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontub
force-pushed
the
dont-lose-state-of-statement
branch
from
c89c879
to
e4e7b63
Compare
|
@Jean85 do you think this can be merged? |
|
Also looking for this feature. |
peelandsee
requested changes
Aug 26, 2019
There was a problem hiding this comment.
hey @dontub ,
thank you so much for your MR!
sorry for the late reply,
we were all on vacation until today.
also, we really appreciate your MR comes with appropriate test-case!
may you have a look at the review and give me your feedback?
thanks again,
|
@dontub merged! we'll tag a new release soon. thank you for your contribution! |
|
@dontub v1.8, released today, contains your merge thanks again, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28.