Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHP 8 support #46

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Added PHP 8 support #46

merged 1 commit into from
Jan 25, 2021

Conversation

gordinskiy
Copy link
Contributor

Can we add support of PHP 8?

Jean85
Jean85 requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please at least add a PHP 8 job in CI to check if it works.

@gordinskiy
Copy link
Contributor Author

PHP 8 job in CI

Added PHP 8 to CI

@Jean85 Jean85 merged commit a124891 into facile-it:master Jan 25, 2021
@alfamegaxq alfamegaxq mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gordinskiy @Jean85