Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach that I followed in #55 revealed to be incomplete:
PrimaryReadReplicaConnection
shouldn't have been deletedTo avoid restoring the
ConnectionTrait
approach, and solve the deprecations issue, I'm trying this approach, that basically consists in using the decorator pattern.It seems to work already with the Mysqli driver, while with PDO it's still failing; I probably need to restore the rebind of parameters to make it work.