Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collectWithIndex function to ReadonlyRecord module #50

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

davidecaruso
Copy link
Member

@davidecaruso davidecaruso commented Sep 29, 2022

Added function to ReadonlyRecord module to collect values preserving indexes.

Copy link
Member

@xzhayon xzhayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to adhere to fp-ts style, it should be collectWithIndex.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Base: 70.52% // Head: 70.56% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (078e284) compared to base (b2275d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   70.52%   70.56%   +0.04%     
==========================================
  Files          47       47              
  Lines        2534     2538       +4     
  Branches      248      248              
==========================================
+ Hits         1787     1791       +4     
  Misses        720      720              
  Partials       27       27              
Impacted Files Coverage Δ
src/ReadonlyRecord.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidecaruso davidecaruso changed the title Add collectWithPreservedIndex function to ReadonlyRecord module Add collectWithIndex function to ReadonlyRecord module Sep 30, 2022
Copy link
Member

@xzhayon xzhayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidecaruso davidecaruso merged commit 7fb2f97 into main Sep 30, 2022
@davidecaruso davidecaruso deleted the add-functions branch September 30, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants