Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow symfony 7 (WIP) #220

Merged
merged 10 commits into from Nov 30, 2023
Merged

Conversation

Chris53897
Copy link

Just a quick check for symfony 7 support.
there are dependencies that do not have symfony 7 support yet.

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work immediately, since we do not have any active deprecation. You broke the build though...

tests/Unit/Logs/TestHook/DeprecationTest.php Outdated Show resolved Hide resolved
@Chris53897
Copy link
Author

CI is green. But there is no testrun for symfony 7.
Maybe wait for 1 or 2 weeks, until there is the first stable release of symfony 7?

@keradus
Copy link

keradus commented Nov 29, 2023

there is stable Sf7 now

@Chris53897
Copy link
Author

I did rerun CI.
Symfony/Console 7 is blocked by facile-it/facile-coding-standard#63

@Jean85 Can you please have a look?

@Jean85 Jean85 added this to the 2.2 milestone Nov 30, 2023
@Jean85 Jean85 merged commit 4f8a7f8 into facile-it:2.x Nov 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants