Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow PHPUnit 11 #228

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests.yaml
Expand Up @@ -13,7 +13,7 @@ jobs:
Tests:
runs-on: 'ubuntu-latest'
env:
SYMFONY_DEPRECATIONS_HELPER: disabled
SYMFONY_DEPRECATIONS_HELPER: disabled
strategy:
matrix:
php:
Expand Down Expand Up @@ -41,6 +41,8 @@ jobs:
with:
php-version: ${{ matrix.php }}
coverage: ${{ matrix.coverage }}
# @TODO: remove line below when vimeo/psalm allow nikic/php-parser:^5
- run: composer remove --dev vimeo/psalm --no-update
- run: composer remove --dev facile-it/facile-coding-standard --no-update
if: matrix.dependencies == 'lowest'
- uses: ramsey/composer-install@v2
Expand Down
6 changes: 5 additions & 1 deletion composer.json
Expand Up @@ -27,7 +27,7 @@
"ext-dom": "*",
"ext-json": "*",
"jean85/pretty-package-versions": "^1.5.1||^2.0.1",
"phpunit/php-code-coverage": "^10.0",
"phpunit/php-code-coverage": "^10.0||^11.0",
"phpunit/php-file-iterator": "^4.0",
Copy link

@Chris53897 Chris53897 Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be "phpunit/php-file-iterator": ^4.0||^5.0

"phpunit/phpunit": "^10.5.4||^11.0",
"psr/event-dispatcher": "^1.0",
Expand Down Expand Up @@ -85,5 +85,9 @@
"suggest": {
"ext-pcov": "A coverage driver for faster collection",
"dama/doctrine-test-bundle": "Useful for Symfony+Doctrine functional testing, providing DB isolation"
},
"scripts": {
"cs-check": "php-cs-fixer fix --dry-run --diff",
"cs-fix": "php-cs-fixer fix --diff"
}
}