Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update setup.py for manual build #217

Merged

Conversation

LeeDongGeon1996
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 commented Apr 13, 2022

Description

  • Don't let setup.py receive its semver from CLI argument.
  • Replace semver in setup.py using sed.

prevents #197.

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 force-pushed the chore/update-manual-build branch 11 times, most recently from 609666a to e3e1883 Compare April 13, 2022 11:24
@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review April 13, 2022 11:35
setup.py Outdated Show resolved Hide resolved
@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) April 15, 2022 05:35
@LeeDongGeon1996 LeeDongGeon1996 merged commit 457f451 into facioquo:main Apr 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
@LeeDongGeon1996 LeeDongGeon1996 deleted the chore/update-manual-build branch June 6, 2022 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants