Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add code coverage #28

Merged
merged 6 commits into from Oct 24, 2021
Merged

chore: add code coverage #28

merged 6 commits into from Oct 24, 2021

Conversation

LeeDongGeon1996
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 commented Oct 12, 2021

THIS DRAFT PR IS STILL WORK IN PROGRESS

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation, context, and sources of information or recipes.

Fixes #

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage
  • I have added or run the performance tests that depict optimal execution times
  • New and existing unit tests pass locally and in the build (below) with my changes

Acknowledgements

@LeeDongGeon1996
Copy link
Member Author

@DaveSkender Can you check code coverage settings and artifact settings in Azure Piplines? Looks like all the settings for code-coverage and artifacts are already set.

@DaveSkender
Copy link
Member

I’ll take a look, but may take a while. It’s probably generating code coverage, but not publishing it. It should look like the build got .NET

A0B23426-60A0-4C21-BC57-FACC418586E0

@LeeDongGeon1996
Copy link
Member Author

FYI, on my screen.
image

@DaveSkender DaveSkender self-assigned this Oct 18, 2021
Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were just missing the publish step. See file diffs.

image

@DaveSkender DaveSkender changed the title chore: ci chore: add code coverage Oct 23, 2021
@DaveSkender
Copy link
Member

On a related note, I've set up the internal package manager, something we can use for intermediate packages before we publish to PyPi or other public package managers. You can access it here: https://dev.azure.com/skender/Stock.Indicators/_packaging?_a=feed&feed=Internal

You can also use this to test it out from a user's perspective.

@LeeDongGeon1996
Copy link
Member Author

Thanks. It works well :)

@LeeDongGeon1996 LeeDongGeon1996 merged commit 7597ec8 into facioquo:main Oct 24, 2021
@LeeDongGeon1996 LeeDongGeon1996 deleted the chore/make-build branch October 24, 2021 07:16
@github-actions
Copy link

This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants