New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate CI & CD to GitHub Actions #322
chore: Migrate CI & CD to GitHub Actions #322
Conversation
3dfe9e5
to
2c19a79
Compare
GPT did it all...👍 |
bea8d20
to
ef5b98b
Compare
@DaveSkender Can you check Azure Pipelines webhook config? It's staying on pending status.
I'm following this guide(Publishing package distribution releases using GitHub Actions CI/CD workflows) and it uses PyPI’s trusted publishing, Can you config for it? |
Also, check for an equivalent auto-draft for the release notes after successful publish to Note: this may need to be configured slightly different if the timing of tagging is different. I didn't think through the scenario, so it may be okay with same implementation. |
I've also removed the required check for the Azure Pipelines build, but will need to add the new CI.yml variant to the branch protection rules once everything's working well here, and probably after this is merged. |
@DaveSkender Thanks for your work :)
Yeah, that's why we need to set deployment protection rules or add review step before deployment |
I really only have one question, how is the release tag introduced on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we'd need to pull out the unused SemVer
stuff like gitversion.yml
, how its written in contributing.md
, and any other integrations that might exist in setup.py
or other places where the version number is stamped.
How does the |
You're right! I'll draft fixed |
If it's not incrementing a pre-release suffix, the publish will get rejected as a duplicate when you commit 2+ times to (oops, sorry, edited your comment accidentally) |
74b1a19
to
5a72ece
Compare
Yeah as I know, setuptool_scm resolve that problem by creating unique version number, let me double check. I've just checked that it creates unique version number by every new commit. |
…1996/Stock.Indicators.Python into chore/mig_cicd_to_gh
Let me know when you're done with |
Yeah, I've already done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my end. Merge when ready.
Description
Fixes #319
Checklist