Save NlohmannParser (JSON) settings #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Save settings when parser is instantiated. - Load settings when the options widget is accessed.
Now settings are saved separately for each encoding. Co-authored-by: Davide Faconti <davide.faconti@gmail.com>
Encoding needs to be part of the base class to allow it to be used in the constructor itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the NlohmannParser (json/bson/cbor/msgpack parsers) options are saved to the user settings file, making especially data streaming easier where we no longer have to specify this option after each restart of the app.
This PR partially solves #839: Settings are now saved, but not as part of the layout file.
Changes:
Design reasoning:
I debated over extending the
ParserFactoryPlugininterface withvoid saveSettings()andvoid loadSettings()to make this feature explicit and controllable by the caller, that also would improve the interface for future plugins.In the end I opted for this simpler more contained solution not to change the architecture, but with the downside of settings being loaded multiple times and both load and save being a side-effect.
I would be happy update the PR with the interface route if you think that is a better approach.
Thanks