add exception handling to download of json datasets #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #7 the GitHub action updating the json data from the Factbook source aborts on downloads from time to time. While the reason for the return HTTP error code 404 remains unclear integrating exception handling does seem reasonable to me. To my understanding it's the main objective of this repo to archive/mirror the contents of the Factbook source. So downloading as much as technically possible does serve this purpose. At least from my own point of view.
I'd like to point out that I lack any experience of coding in ruby so please double check the code for any typos.