Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-initialization causes duplication of gRPC headers #2868

Closed
bresciamattia opened this issue May 3, 2024 · 0 comments · Fixed by #2872
Closed

Re-initialization causes duplication of gRPC headers #2868

bresciamattia opened this issue May 3, 2024 · 0 comments · Fixed by #2872
Assignees
@bresciamattia

Comments

@bresciamattia
Copy link
Collaborator

Describe the bug
Upon re-initialization of the GrpcFactStore (e.g. during resilient subscription reconnect due to fc server being deployed), the gRPC headers of the handshake are duplicated.
This could result in the client not being able to connect again, due to header size exceeded.

FactCast Server/Client Version
0.7.5 to 0.7.6

To Reproduce
Trigger onError on a subscribed projection to resubscribe, multiple times.

Expected behavior
The gRPC message headers should not be duplicated.
@bresciamattia bresciamattia self-assigned this May 3, 2024
bresciamattia pushed a commit that referenced this issue May 3, 2024
#2868: WIP recreate stubs on initialization
efc5b30
bresciamattia pushed a commit that referenced this issue May 6, 2024
#2868: set dirtiesContext for flaky integration tests
7233a5c
bresciamattia pushed a commit that referenced this issue May 6, 2024
#2868: add integration test for re-initialization
fd2a022
bresciamattia pushed a commit that referenced this issue May 6, 2024
#2868: add factory for grpc stubs
e8e2aa7
bresciamattia pushed a commit that referenced this issue May 6, 2024
#2868: cleanup
6d0d014
bresciamattia pushed a commit that referenced this issue May 7, 2024
#2868: cleanup and add integration test
cda9eaa
@bresciamattia bresciamattia linked a pull request May 7, 2024 that will close this issue
#2868: Re-initialization causes duplication of gRPC headers #2872
Merged
bresciamattia pushed a commit that referenced this issue May 7, 2024
#2868: cleanup
e3b9621
bresciamattia pushed a commit that referenced this issue May 7, 2024
#2868: enable authentication on all interface methods
6928ffe
bresciamattia pushed a commit that referenced this issue May 13, 2024
#2868: improve tests coverage
0d484fc
bresciamattia pushed a commit that referenced this issue May 13, 2024
#2868: fix code smell issues
6f69ffc
bresciamattia pushed a commit that referenced this issue May 21, 2024
#2868: cleanup, add tests and translate AuthenticationExceptions on t…
46ee15e 
…he server side
uweschaefer added a commit that referenced this issue May 28, 2024
@uweschaefer
#2868: few sonar & warnings removed
f13a2a0
bresciamattia pushed a commit that referenced this issue Jun 3, 2024
#2868: decrease number of retries in testMultipleRetriesWithResponse …
5e7744a 
…after having maxed out the value of GrpcStoreResilienceITest.NUMBER_OF_ATTEMPTS
uweschaefer added a commit that referenced this issue Jun 3, 2024
@uweschaefer
#2868: super minor cleanup
353c676
@uweschaefer uweschaefer mentioned this issue Jun 3, 2024
Merged
uweschaefer added a commit that referenced this issue Jun 3, 2024
@uweschaefer
Merge pull request #2872 from factcast/issue2868
0b9893f 
#2868: Re-initialization causes duplication of gRPC headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bresciamattia bresciamattia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2868: Re-initialization causes duplication of gRPC headers factcast/factcast
1 participant
@bresciamattia