Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-initialization causes duplication of gRPC headers #2868

Closed
bresciamattia opened this issue May 3, 2024 · 0 comments · Fixed by #2872
Closed

Re-initialization causes duplication of gRPC headers #2868

bresciamattia opened this issue May 3, 2024 · 0 comments · Fixed by #2872
Assignees

Comments

@bresciamattia
Copy link
Collaborator

Describe the bug
Upon re-initialization of the GrpcFactStore (e.g. during resilient subscription reconnect due to fc server being deployed), the gRPC headers of the handshake are duplicated.
This could result in the client not being able to connect again, due to header size exceeded.

FactCast Server/Client Version
0.7.5 to 0.7.6

To Reproduce
Trigger onError on a subscribed projection to resubscribe, multiple times.

Expected behavior
The gRPC message headers should not be duplicated.

@bresciamattia bresciamattia self-assigned this May 3, 2024
bresciamattia pushed a commit that referenced this issue May 6, 2024
bresciamattia pushed a commit that referenced this issue May 6, 2024
bresciamattia pushed a commit that referenced this issue May 7, 2024
bresciamattia pushed a commit that referenced this issue May 13, 2024
bresciamattia pushed a commit that referenced this issue May 13, 2024
bresciamattia pushed a commit that referenced this issue Jun 3, 2024
…after having maxed out the value of GrpcStoreResilienceITest.NUMBER_OF_ATTEMPTS
uweschaefer added a commit that referenced this issue Jun 3, 2024
uweschaefer added a commit that referenced this issue Jun 3, 2024
#2868: Re-initialization causes duplication of gRPC headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant