Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PgSQL test setup polish #438

Closed
uweschaefer opened this issue Jun 21, 2019 · 2 comments
Closed

PgSQL test setup polish #438

uweschaefer opened this issue Jun 21, 2019 · 2 comments
Labels

Comments

@uweschaefer
Copy link
Member

From @mweirauch on 2019-05-22 21:17:45 +0000 UTC

What this PR does:

  • clean up some unused files in in the pgsql store test resources
  • adds a slf4j simplelogger.properties for easier debug level toggling
  • renames PgEmbeddedConfiguration to PgTestConfiguration to better reflect its purpose

Which issue(s) this PR relates to or fixes:
None.

Notes for the reviewer:

  • This PR has no influence on the runtime.
  • What does the reviewer think of PR templates? (Inspired by this one.)

Copied from original issue: Mercateo/factcast#438

@uweschaefer
Copy link
Member Author

From @uweschaefer on 2019-05-22 21:25:25 +0000 UTC

thx @mweirauch

@uweschaefer
Copy link
Member Author

From @codecov[bot] on 2019-05-22 21:49:23 +0000 UTC

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          78       78           
  Lines        1870     1870           
  Branches      169      169           
=======================================
  Hits         1664     1664           
  Misses        126      126           
  Partials       80       80

uweschaefer added a commit that referenced this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant