Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2333: Read-only configuration #2334

Merged
merged 35 commits into from Oct 12, 2023
Merged

#2333: Read-only configuration #2334

merged 35 commits into from Oct 12, 2023

Conversation

otbe
Copy link
Member

@otbe otbe commented Aug 22, 2023

closes #2333

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2334 (cf8438a) into master (4ee9940) will increase coverage by 88.37%.
The diff coverage is 94.37%.

@@              Coverage Diff              @@
##             master    #2334       +/-   ##
=============================================
+ Coverage          0   88.37%   +88.37%     
- Complexity        0     1829     +1829     
=============================================
  Files             0      307      +307     
  Lines             0     6970     +6970     
  Branches          0      513      +513     
=============================================
+ Hits              0     6159     +6159     
- Misses            0      642      +642     
- Partials          0      169      +169     

@otbe otbe changed the title [WIP] #2333: Read-only configuration #2333: Read-only configuration Aug 30, 2023
@otbe otbe requested a review from uweschaefer August 30, 2023 07:50
Copy link
Contributor

@bedaka bedaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found some typos in comments.

otbe and others added 8 commits October 11, 2023 09:08
…ache/SnapshotCacheCompactor.java

Co-authored-by: Benedikt Kaiser <33041245+bedaka@users.noreply.github.com>
…tionProperties.java

Co-authored-by: Benedikt Kaiser <33041245+bedaka@users.noreply.github.com>
# Conflicts:
#	factcast-store/src/main/java/org/factcast/store/registry/validation/schema/store/PgSchemaStoreImpl.java
# Conflicts:
#	factcast-store/src/test/java/org/factcast/store/internal/PgFactStoreTest.java
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

63.6% 63.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@otbe otbe merged commit b0ae2f6 into master Oct 12, 2023
9 of 10 checks passed
@otbe otbe deleted the issue2333 branch October 12, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow read-only deployment of factcast server
3 participants