Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2340: Possbile OOM/buffer overflow in BufferingFactInterceptor #2341

Merged
merged 4 commits into from Sep 1, 2023

Conversation

otbe
Copy link
Member

@otbe otbe commented Aug 31, 2023

closes #2340

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2341 (7a6fe87) into master (03e4f79) will increase coverage by 0.59%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 7a6fe87 differs from pull request most recent head 87c07f5. Consider uploading reports for the commit 87c07f5 to get more accurate results

@@             Coverage Diff              @@
##             master    #2341      +/-   ##
============================================
+ Coverage     87.70%   88.28%   +0.59%     
- Complexity     1791     1803      +12     
============================================
  Files           302      302              
  Lines          6900     6902       +2     
  Branches        506      507       +1     
============================================
+ Hits           6051     6093      +42     
+ Misses          681      640      -41     
- Partials        168      169       +1     

@otbe otbe requested a review from uweschaefer August 31, 2023 12:49
@otbe
Copy link
Member Author

otbe commented Aug 31, 2023

mem consumption before ~unlimited afterwards ~200mb while processing 20m facts 😎

Copy link
Member

@uweschaefer uweschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uweschaefer uweschaefer merged commit 5eda2f7 into master Sep 1, 2023
8 checks passed
@uweschaefer uweschaefer deleted the issue2340 branch September 1, 2023 09:16
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible OOM/buffer overflow in BufferingFactInterceptor in heavy load sitautions
2 participants