Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue2578 simplyfication suggestion #2737

Merged
merged 31 commits into from Feb 22, 2024
Merged

Issue2578 simplyfication suggestion #2737

merged 31 commits into from Feb 22, 2024

Conversation

uweschaefer
Copy link
Member

No description provided.

Benedikt Kaiser and others added 25 commits January 25, 2024 15:40
2578: execute handshake when reconnecting
2fde59b
2578: update test
06e9abc
2578: add logging and add int test
3727be0
@bedaka @github-actions
Apply formatter
a611e71
2578: ensure only one handshake is executed when reconnecting
c68f341
Merge remote-tracking branch 'origin/issue2578-handshake-before-recon…
dea6c95 
…nect' into issue2578-handshake-before-reconnect

# Conflicts:
#	factcast-client-grpc/src/main/java/org/factcast/client/grpc/GrpcFactStore.java
@bedaka @github-actions
Apply formatter
1e7b523
2578: fix test
de03f21
Merge remote-tracking branch 'origin/issue2578-handshake-before-recon…
d866cd8 
…nect' into issue2578-handshake-before-reconnect
2578: invoke handshake when retrying to publish
0665df3
2578: add integration test
2c38653
#2578-handshake-before-reconnect: add mocks to fix retriesRun() test
2d54928
2578-handshake-before-reconnect: Merge remote-tracking branch 'origin…
95e458d 
…/master' into issue2578-handshake-before-reconnect
#2578-handshake-before-reconnect: add reinitialization to callAndHandle
1c76e3c
@uweschaefer
Merge branch 'master' into issue2578-handshake-before-reconnect
2954ba3
#2578-handshake-before-reconnect: merge master into issue2578-handsha…
abfb6af 
…ke-before-reconnect
#2578-handshake-before-reconnect: Merge remote-tracking branch 'origi…
72ffaf0 
…n/issue2578-handshake-before-reconnect' into issue2578-handshake-before-reconnect
@uweschaefer
Merge branch 'master' into issue2578-handshake-before-reconnect
fe313b0
2578-handshake-before-reconnect: Merge remote-tracking branch 'origin…
00a393f 
…/master' into issue2578-handshake-before-reconnect
2578-handshake-before-reconnect: Merge branch 'issue2578-handshake-be…
3cac185 
…fore-reconnect' of github.com:factcast/factcast into issue2578-handshake-before-reconnect
@uweschaefer
Merge branch 'master' into issue2578-handshake-before-reconnect
a805713
@uweschaefer
Merge branch 'master' into issue2578-handshake-before-reconnect
dffb4c5
@uweschaefer
Merge branch 'master' into issue2578-handshake-before-reconnect
1bfcd6e
@uweschaefer
#2578-simplyfication-suggestion: suggestion
190791e
@uweschaefer
Merge branch 'master' into issue2578-simplyfication-suggestion
f8a3963
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited

Codecov Report

Merging #2737 (1e6003f) into master (fab94fd) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 84.62%.

❗ Current head 1e6003f differs from pull request most recent head 0497041. Consider uploading reports for the commit 0497041 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2737      +/-   ##
============================================
+ Coverage     88.44%   88.46%   +0.03%     
- Complexity     1958     1959       +1     
============================================
  Files           327      327              
  Lines          7313     7321       +8     
  Branches        535      535              
============================================
+ Hits           6467     6476       +9     
+ Misses          681      680       -1     
  Partials        165      165

bedaka
bedaka approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@bedaka bedaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. I'll approve this PR & execute final QC on ENT

@bedaka bedaka mentioned this pull request Feb 15, 2024
Closed
@uweschaefer
Copy link
Member Author

it looks like, we turned one test flaky:

INFO  [      factcast/factcast:latest] Container factcast/factcast:latest started in PT5.940821141S
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.573 s -- in org.factcast.itests.factus.client.DatabaseUnhealthyITest
[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    GrpcStoreResilienceITest.testConcurrentRetryBehaviorWithoutResponse:131 
Expecting value to be true but was false
[INFO] 
Error:  Tests run: 101, Failures: 1, Errors: 0, Skipped: 0

@uweschaefer uweschaefer merged commit f557328 into master Feb 22, 2024
5 checks passed
@uweschaefer uweschaefer deleted the issue2578-simplyfication-suggestion branch February 22, 2024 12:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedaka bedaka bedaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uweschaefer @bedaka