Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue2878 #2938

Merged
merged 29 commits into from
Jun 13, 2024
Merged

Issue2878 #2938

merged 29 commits into from
Jun 13, 2024

Conversation

uweschaefer
Copy link
Member

@uweschaefer uweschaefer commented Jun 3, 2024 •
edited

closes #2878

@uweschaefer uweschaefer changed the base branch from master to 0.8.0-rc June 3, 2024 10:26
@uweschaefer uweschaefer marked this pull request as draft June 3, 2024 10:26
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited

Codecov Report

Attention: Patch coverage is 88.88889% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.91%. Comparing base (75315cd) to head (4e52f7c).
Report is 180 commits behind head on 0.8.0-rc.

Additional details and impacted files 
@@              Coverage Diff               @@
##             0.8.0-rc    #2938      +/-   ##
==============================================
- Coverage       88.92%   88.91%   -0.00%     
- Complexity       1949     2003      +54     
==============================================
  Files             323      328       +5     
  Lines            7253     7248       -5     
  Branches          512      505       -7     
==============================================
- Hits             6449     6444       -5     
- Misses            650      661      +11     
+ Partials          154      143      -11

@uweschaefer uweschaefer marked this pull request as ready for review June 4, 2024 14:29
@uweschaefer uweschaefer requested a review from otbe June 4, 2024 14:29
@uweschaefer uweschaefer requested a review from otbe June 13, 2024 13:22
otbe
otbe approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@otbe otbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uweschaefer and others added 4 commits June 13, 2024 16:52
@uweschaefer
Update extend-projection-db-support.md
8422331 
updated to latest interface names (sorry me)
@uweschaefer @github-actions
Apply formatter
e0e43f0
@uweschaefer @bedaka
Update factcast-site/documentation-docsy/content/en/Usage/Hitchhikers…
28f6e73 
…Guide/extend-projection-db-support.md

Co-authored-by: Benedikt Kaiser <33041245+bedaka@users.noreply.github.com>
@uweschaefer
Merge pull request #2945 from factcast/issue1390-document-projection-…
4e52f7c 
…db-support

Issue1390 document projection db support
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uweschaefer uweschaefer merged commit 86a76e0 into 0.8.0-rc Jun 13, 2024
6 of 7 checks passed
@uweschaefer uweschaefer deleted the issue2878 branch June 13, 2024 16:33
@uweschaefer uweschaefer mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otbe otbe otbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uweschaefer @otbe @bedaka