Fix bug #25 for GHC 9.4 and text-2 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text-2 switched from UTF-16 to UTF-8, so we need to adjust our pointer logic.
sternenseemann
approved these changes
May 19, 2023
|
@sternenseemann @tvh we should merge this PR. Who has the rights to do so? |
tvh
suggested changes
May 26, 2023
There was a problem hiding this comment.
@skogsbaer We depend on the hashes being stable. This would therefore be a breaking change. Do you see a way to still use UTF-16 in the new version? Maybe via Data.Text.Lazy?
|
Lazy text also uses UTF-8 internally (it's just a list of strict tests). I don't see a way to retain backwards compatibility without introducing a performance overhead, e.g. by converting UTF-8 to UTF-16 to do the hashing. |
|
I agree there is no way to avoid that overhead. The reason why I mentioned lazy text is that it would avoid having to have all in memory at the same time. |
sternenseemann
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Jul 3, 2023
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
rvl
pushed a commit
to rvl/nixpkgs
that referenced
this pull request
Jul 19, 2023
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
rvl
pushed a commit
to rvl/nixpkgs
that referenced
this pull request
Jul 20, 2023
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
rvl
pushed a commit
to rvl/nixpkgs
that referenced
this pull request
Jul 25, 2023
A potential fix for the problem is still in discussion: factisresearch/large-hashable#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.