Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSA keys export format #13

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Fix RSA keys export format #13

merged 2 commits into from
Sep 14, 2019

Conversation

PeterAsenov22
Copy link
Collaborator

No description provided.

sanchopansa
sanchopansa approved these changes Sep 14, 2019
View reviewed changes
Copy link
Contributor

@sanchopansa sanchopansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should keep in mind that it might be possible to add at some the functionality to import an existing DID from a JSON file in the extension, but for now I don't think that's necessary. We can always get the code from the Git history as well.

@sanchopansa sanchopansa merged commit 8b3a2c6 into master Sep 14, 2019
@sanchopansa sanchopansa deleted the fix-rsa-keys-export-format branch September 14, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchopansa sanchopansa sanchopansa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterAsenov22 @sanchopansa