-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system
to standard word search list such that calling exit
/(exit)
does not first issue an error
#2937
Comments
Ctrl-D or closing window isn’t a solution?On Jan 25, 2024, at 9:23 AM, nomennescio ***@***.***> wrote:
Exiting the (UI) listener is a basic operation. Add system to the standard word search order, so the user can exit without getting annoying error messages.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Ctrl-D doesn't close the UI. |
Does the user think |
I don't know of course, but having used quite some interpreters, typing a keyword to close everything is pretty standard.
I still think |
Searching through the vocabs, the only other vocab that defines Looking at the command-line listener, Maybe the more elegant solution is to introduce an alias in the UI Listener for I'll make a pull request out of that, and then you can comment on that, and if you agree accept it, or reject it. Then I'll close this issue. |
Hmm, just adding the alias to |
What’s wrong with Ctrl-D for EOF?Works in command line and UI listeners?On May 9, 2024, at 1:02 AM, nomennescio ***@***.***> wrote:
Searching through the vocabs, the only other vocab that defines exit is cuda.ptx, where it is a tuple.
Looking at the command-line listener, return is required to "exit" it (https://docs.factorcode.org/content/article-listener.html), which is a bit uncommon, but then again, it's not a common way to run Factor, so that is less of a concern.
Maybe the more elegant solution is to introduce an alias in the UI Listener for com-exit; it won't affect existing code, doesn't introduce all system words in the global vocab search space, and is limited to the UI Listener only, and only clashes if the user explicitly loads system in scratchpad and defines words with that.
I'll make a pull request out of that, and then you can comment on that, and if you agree accept it, or reject it. Then I'll close this issue.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
As noted |
But they likely don't expect it to exit Factor, they likely expect it to exit one of the listener windows, no? |
How do you type an EOF on windows? |
|
As I said, I find that hard to predict; typically people start an interpreter from the commandline ( |
With the solution for #3004 , Therefore the word to properly end the listener is Maybe we can have an easier to remember |
I propose |
I don’t like this word, but I’m not going to immediately revert it. You have at least two keyboard shortcuts and can close the window. I don’t think this alias is a good idea. Let’s let it bake for a bit before I decide. On May 29, 2024, at 5:47 AM, nomennescio ***@***.***> wrote:
a50f45c
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
You can also add this to your install using factor-rc or factor-boot-rcOn May 29, 2024, at 5:47 AM, nomennescio ***@***.***> wrote:
a50f45c
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
I’d be more interested in making Ctrl-D work across all platforms On May 29, 2024, at 5:47 AM, nomennescio ***@***.***> wrote:
a50f45c
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Reverting, if you need this you can make an alias in your factor-rc / factor-boot-rc. |
Ctrl-D works on windows |
Exiting the (UI) listener is a basic operation. Add
system
to the standard word search order, so the user can exit without getting annoying error messages.The text was updated successfully, but these errors were encountered: