Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quit to system, add system to default search path, to let user have readily available command to quit Factor #3030

Closed
nomennescio opened this issue Jun 2, 2024 · 8 comments

Comments

@nomennescio
Copy link
Contributor

See also #2937.

John's comment about that:
"add quit as an alias for 0 exit in system, and then close-all-windows as a shutdown hook, and then add system as a normal used vocab"

@nomennescio
Copy link
Contributor Author

@mrjbq7 , question about this implementation scheme; currently 0 exit hard exits without calling close-all-windows, would calling close-all-windows at shutdown be safe to deal with a Factor that's not responsive in UI code or has a bug in e.g. user code?

@nomennescio
Copy link
Contributor Author

@mrjbq7 I noticed you already (partially) implemented this. Doesn't ce2bc44 also not require a call to notify-queued?

@mrjbq7
Copy link
Member

mrjbq7 commented Jun 2, 2024 via email

@mrjbq7
Copy link
Member

mrjbq7 commented Jun 2, 2024 via email

@mrjbq7
Copy link
Member

mrjbq7 commented Jun 2, 2024

Maybe this fixes if bfb58c5

@mrjbq7 mrjbq7 closed this as completed Jun 2, 2024
@mrjbq7 mrjbq7 reopened this Jun 2, 2024
@mrjbq7
Copy link
Member

mrjbq7 commented Jun 2, 2024

Except for the USE: system which is a restart which is fine for now, I don't know if os/cpu/vm-* stuff makes sense to be in the normal using, have to think about it.

What do you think?

@nomennescio
Copy link
Contributor Author

Except for the USE: system which is a restart which is fine for now, I don't know if os/cpu/vm-* stuff makes sense to be in the normal using, have to think about it.

What do you think?

It works fine at my end; but would like to have either system in the standard search path, or in another vocab that's loaded at startup such that quit always works.

@mrjbq7
Copy link
Member

mrjbq7 commented Jun 6, 2024

Fixed in 938d99b.

@mrjbq7 mrjbq7 closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants