fix(shortcodes/image): explicit disable useCache #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvsde
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
In the future, useCache: false should again be removed so eleventy-img can use the image cache again.
This is especially important for webp and AVIF because their encoders are a lot slower than JPEG. Fun fact: when I delete the image cache for my personal website it takes ~5 minutes to regenerate 265 images.
@mgrsskls I would attribute this to lack of time. You can go ahead and merge this. Things will probably change anyway when we upgrade to Eleventy Image v4 with its new zero configuration shortcode-less image handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid any caching problems the useCache is disabled explicit. Solves #32
Watchout: This is just a temp solutions and must be refactored after the shortcodes cleanup currently in the making.