Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

massTotal not being set to zero in efficient lda example #105

Open
dirkweissenborn opened this issue Dec 7, 2013 · 1 comment
Open

massTotal not being set to zero in efficient lda example #105

dirkweissenborn opened this issue Dec 7, 2013 · 1 comment

Comments

@dirkweissenborn
Copy link
Contributor

In the efficient lda example the phis for example are set to zero and reestimated in the export method of the SparseLDAInferencer. However, massTotal of the phis is not set back to 0 and so the Proportions get messed up. I worked around that by decrementing each mass manually to zero before the export call. like that the masstotal also gets decreased to zero.

@llasram
Copy link

llasram commented Oct 22, 2014

I'm seeing the effect of this as well in release 1.0, although I'm not sure failing to reset the massTotal is the problem. The SparseLDAInferencer export() method begins with phis.foreach(_.value.zero()), which as I read the code (albeit not really knowing Scala) should be reseting the masses. However, dumping the total mass of the phis shows that it increases with each export(). There's definitely a bug in there somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants