Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardTitle, CardSubtitle fix #187

Closed
tcbegley opened this issue Apr 22, 2019 · 1 comment
Closed

CardTitle, CardSubtitle fix #187

tcbegley opened this issue Apr 22, 2019 · 1 comment

Comments

@tcbegley
Copy link
Collaborator

tcbegley commented Apr 22, 2019

In the old version of reactstrap we were using, CardTitle and CardSubtitle were rendered with h5 and h6 tags by default. In newer version the defaults were changed to div, so the components currently only modify margin-bottom. This can be overwritten using the tag prop, e.g.

dbc.CardTitle("This is the title", tag="h2")

but it's not very idiomatic to Dash I think.

There's a few options:

  1. We could revert the defaults by setting them to the old defaults in our wrappers.
  2. Leave the defaults as they are, encourage usage of the tag prop.
  3. Deprecate the components, and instead encourage people to use the html.H* component of their choice, with className="card-(sub)title". While this may seem drastic, the components themselves are a pretty heavy handed way of ultimately just applying some pretty lightweight CSS classes.

I think I'm leaning towards option 3.

@tcbegley
Copy link
Collaborator Author

Resolved by #193, documentation updated in #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant