You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the old version of reactstrap we were using, CardTitle and CardSubtitle were rendered with h5 and h6 tags by default. In newer version the defaults were changed to div, so the components currently only modify margin-bottom. This can be overwritten using the tag prop, e.g.
dbc.CardTitle("This is the title", tag="h2")
but it's not very idiomatic to Dash I think.
There's a few options:
We could revert the defaults by setting them to the old defaults in our wrappers.
Leave the defaults as they are, encourage usage of the tag prop.
Deprecate the components, and instead encourage people to use the html.H* component of their choice, with className="card-(sub)title". While this may seem drastic, the components themselves are a pretty heavy handed way of ultimately just applying some pretty lightweight CSS classes.
I think I'm leaning towards option 3.
The text was updated successfully, but these errors were encountered:
In the old version of reactstrap we were using,
CardTitle
andCardSubtitle
were rendered withh5
andh6
tags by default. In newer version the defaults were changed todiv
, so the components currently only modifymargin-bottom
. This can be overwritten using thetag
prop, e.g.but it's not very idiomatic to Dash I think.
There's a few options:
tag
prop.html.H*
component of their choice, withclassName="card-(sub)title"
. While this may seem drastic, the components themselves are a pretty heavy handed way of ultimately just applying some pretty lightweight CSS classes.I think I'm leaning towards option 3.
The text was updated successfully, but these errors were encountered: