Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button / ButtonGroup documentation #175

Merged
merged 2 commits into from Apr 7, 2019
Merged

Button / ButtonGroup documentation #175

merged 2 commits into from Apr 7, 2019

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Apr 4, 2019

This PR improves the documentation for Button and adds separate documentation for ButtonGroup.

It also exposes the group prop of DropdownMenu so that it can be used inside a ButtonGroup, which I realised was an issue while preparing the documentation.

image

image

@pbugnion
Copy link
Member

pbugnion commented Apr 7, 2019

Since we're modifying this documentation, should we also change the description of n_clicks_timestamp to suggest using Dash's callback_context instead of n_clicks_timestamp?

src/components/DropdownMenu.js Outdated Show resolved Hide resolved
@pbugnion
Copy link
Member

pbugnion commented Apr 7, 2019

Looks great!

I made a couple of comments inline, but merge whenever.

@tcbegley tcbegley merged commit 5dde5a6 into master Apr 7, 2019
2 checks passed
@tcbegley tcbegley deleted the button-documentation branch Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants