Button / ButtonGroup documentation #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we're modifying this documentation, should we also change the description of |
pbugnion
reviewed
Apr 7, 2019
|
Looks great! I made a couple of comments inline, but merge whenever. |
tcbegley
force-pushed
the
button-documentation
branch
from
d3e21e5
to
a25618b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation for
Buttonand adds separate documentation forButtonGroup.It also exposes the
groupprop ofDropdownMenuso that it can be used inside aButtonGroup, which I realised was an issue while preparing the documentation.