-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Isolate scope directive disallowing the use of other directives on form element. #22
Comments
Could you have a look at this please? It's the only thing that prevents me from updating to the new version with all the bugs fixed. Would you like me to commit a PR with the fix? |
Check it out, should be fixed now in 0.2.3-alpha.2 On Mon, Nov 3, 2014 at 4:32 AM, wawyed notifications@github.com wrote:
Matt Miller Web Master Superpedestrian Inc. This message is intended only for the addressee named above. If you are |
Thank you :) |
Make sure to use |
In 0.2+ there was introduced the use of isolate scope in unsavedChangesForm directive. This makes impossible for other directives that create child scopes to work in the same element as the form directive.
Do you actually need to create an scope at all for the directive, seems rather unnecessary. If you do require to isolate the scope could you at least make the directive require the form controller at parent level as well as element ( as in require: '^form') so we can move the unsavedChangesForm directive to a stand alone element inside a form.
The text was updated successfully, but these errors were encountered: