Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan other kinds of barcodes? #1

Closed
ghunter99 opened this issue Jul 23, 2018 · 3 comments
Closed

scan other kinds of barcodes? #1

ghunter99 opened this issue Jul 23, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghunter99
Copy link

Great job with this plug in!
Do you have any interest in making the plug in work with other kinds of barcodes?
Thinking that it would be relatively straight forward :) & would widen it's appeal.

@facundomedica
Copy link
Owner

Thanks for opening this issue, I was going to open it myself as a reminder.
Yes, scanning other codes is definitely in my plans, and as you said it should be quite easy. An enum in the dart interface and a handler (a for loop that adds the accepted types to an array) for that in each platform code should do the trick.

Let me know if you would like to send a pull request for this, if not, I'll try to tackle this during the week.

If you have other suggestions feel free to open issues!

@facundomedica facundomedica added enhancement New feature or request good first issue Good for newcomers labels Jul 23, 2018
@facundomedica
Copy link
Owner

facundomedica commented Jul 23, 2018

I've already implemented this, but I don't have an iPhone to test it at the moment. I will push it to Github so you can give it a try. After I tested it I will publish to pub.dartlang.org.

Can you test it and give me feedback? Thanks!

@facundomedica facundomedica added the help wanted Extra attention is needed label Jul 23, 2018
@facundomedica
Copy link
Owner

facundomedica commented Jul 24, 2018

Ok, I fixed the iOS scanning and pushed everything.

Now you have to pass an array of CodeFormat when the controller is initialized. The reason why I chose to do this instead of just scanning everything is because it's faster. If I had just let it scan everything, things would be much slower for people who just wants to scan one or two code formats.

Reference:

Scan for all supported barcode formats at once, without having to specify the format you're looking for. Or, boost scanning speed by restricting the detector to only the formats you're interested in.

https://firebase.google.com/docs/ml-kit/read-barcodes?hl=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants